Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Direction Of Trade Statistics From IMF #6683

Merged
merged 4 commits into from
Sep 22, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • Expands the macroeconomic coverage with data of trade flows between countries and major areas of the world.
    • One could make super-fancy maps to visually present this data.
  2. What?:

    • Adds new route: obb.economy.direction_of_trade
      • Data is from IMF.
      • Multiple countries allowed for both the country and counterpart parameters.
        • Can compare one (or more) country vs. one, several, or all countries and vice-versa.
        • Cannot compare all countries vs. all countries.
      • Choice for the data value: "imports", "exports", "balance", "all"
      • Frequency of the data can be one of: "month", "quarter", "annual"
      • Some cohorts of countries have annual data going back to 1948.
  3. Impact:

    • Additional stuff to maintain. If other providers are supplying this data in the future, it is likely the same data.
  4. Testing Done:

    • Integration/Unit
    • Blasted functions until I got rate-limited - have attempted to handle that specific error so it is not "unknown error".

Screenshot 2024-09-20 at 5 00 51 PM

Screenshot 2024-09-20 at 5 09 48 PM

@deeleeramone deeleeramone added enhancement Enhancement platform OpenBB Platform v4 PRs for v4 labels Sep 21, 2024
Copy link
Contributor

@IgorWounds IgorWounds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@IgorWounds IgorWounds added this pull request to the merge queue Sep 22, 2024
Merged via the queue into develop with commit 12b4863 Sep 22, 2024
10 checks passed
@IgorWounds IgorWounds deleted the feature/direction-of-trade branch September 26, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change enhancement Enhancement platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants