-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/openbb apachebeam #6679
Feature/openbb apachebeam #6679
Conversation
…tils/senate_constants.py file in another bramnch
…tils/senate_helpers.py file belong to antothe rbranch
examples/openbb-apachebeam/README.md
Outdated
- You need to create a Conda environment (or a virtual env) using requirements.txt in this directory | ||
- The script exercise 3 OBB endpoints, all of which require no credentials | ||
- Run the test from the main directory | ||
(obb-dataflow) C:\Users\Marco And Sofia\tmp\OBBDataflowSample>python -m unittest .\tests\test_obb_pipeline.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go in a code block, and we don't want to include anything that isn't exactly what anyone needs to enter on the command line.
python -m unittest tests/test_obb_pipeline.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, thanks, apologies i will bear in mind for next time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmistroni This really looks great. I would like to merge this.
Could you please update the markdown like @deeleeramone mentioned?
instead of the line that says
(obb-dataflow) C:\Users\Marco And Sofia\tmp\OBBDataflowSample>python -m unittest .\tests\test_obb_pipeline.py
put
python -m unittest tests/test_obb_pipeline.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will approve it, but I it would be great that the path mentioned in the comment to be removed before this is merged
examples/openbb-apachebeam/README.md
Outdated
- You need to create a Conda environment (or a virtual env) using requirements.txt in this directory | ||
- The script exercise 3 OBB endpoints, all of which require no credentials | ||
- Run the test from the main directory | ||
(obb-dataflow) C:\Users\Marco And Sofia\tmp\OBBDataflowSample>python -m unittest .\tests\test_obb_pipeline.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmistroni This really looks great. I would like to merge this.
Could you please update the markdown like @deeleeramone mentioned?
instead of the line that says
(obb-dataflow) C:\Users\Marco And Sofia\tmp\OBBDataflowSample>python -m unittest .\tests\test_obb_pipeline.py
put
python -m unittest tests/test_obb_pipeline.py
sure.. i will fix that tomorrow morning....sorry abt that
…On Tue, Sep 24, 2024 at 6:00 PM Theodore Aptekarev ***@***.***> wrote:
***@***.**** approved this pull request.
I will approve it, but I it would be great that the path mentioned in the
comment to be removed before this is merged
------------------------------
In examples/openbb-apachebeam/README.md
<#6679 (comment)>
:
> @@ -0,0 +1,12 @@
+# OBB Dataflow Sample
+
+
+This is a sample how to invoke OBB fetchers in an Apache Beam pipeline. (GCP dataflow is build on Apache Beam)
+Pre-requisites
+- You need to create a Conda environment (or a virtual env) using requirements.txt in this directory
+- The script exercise 3 OBB endpoints, all of which require no credentials
+- Run the test from the main directory
+ (obb-dataflow) C:\Users\Marco And Sofia\tmp\OBBDataflowSample>python -m unittest .\tests\test_obb_pipeline.py
@mmistroni <https://github.com/mmistroni> This really looks great. I
would like to merge this.
Could you please update the markdown like @deeleeramone
<https://github.com/deeleeramone> mentioned?
instead of the line that says
(obb-dataflow) C:\Users\Marco And Sofia\tmp\OBBDataflowSample>python -m
unittest .\tests\test_obb_pipeline.py
put
python -m unittest tests/test_obb_pipeline.py
—
Reply to this email directly, view it on GitHub
<#6679 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACPNCDXNLQXNIMSQ33GGKA3ZYGLBJAVCNFSM6AAAAABOQLKKTWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMRVHA3DSNZRG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
fixed comment
i have committed a version with fixes you require... pls advise if all good o/w will address it tomorrow morning. sorry abt this |
@deeleeramone I'm good with the changes, feel free to merge once you take a look at it. |
Pull Request Template for OpenBB Developers
Title:
Why? (1-3 sentences or a bullet point list):
What? (1-3 sentences or a bullet point list):
Impact (1-2 sentences or a bullet point list):
Testing Done:
Reviewer Notes (optional):
Done amendments as suggested by @deeleeramone : depends on obb yfinance and revised README and instructions
Example: "Please check algorithm compatibility with existing data models."
Any other information (optional)