Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add EIA Daily Spot Prices Data via FRED #6677

Merged
merged 15 commits into from
Oct 3, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • To start building within the commodity module.
    • Quick win by curating some FRED series IDs.
  2. What?:

    • New endpoint: obb.commodity.spot_prices
    • Adds daily time series data from the EIA spot prices API via FRED, and includes the metadata.
      • The list of commodities is fixed, added "commodity" as a provider parameter to allow variations between providers (future). Choices are:
        • "wti",
        • "brent",
        • "natural_gas",
        • "jet_fuel",
        • "propane",
        • "heating_oil",
        • "diesel_gulf_coast",
        • "diesel_ny_harbor",
        • "diesel_la",
        • "gasoline_ny_harbor",
        • "gasoline_gulf_coast",
        • "rbob",
        • "all"
    • The lbma_fixing endpoint from Nasdaq DataLink appears to be dead, commented out the fetcher and skipped those tests.
  3. Impact:

    • openbb-commodity will populate with a function without installing any extras.
  4. Testing Done:

    • Integration/unit

image

@deeleeramone deeleeramone added enhancement Enhancement platform OpenBB Platform labels Sep 18, 2024
Copy link
Contributor

@IgorWounds IgorWounds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is good. We need to align what is the best way to deal with the LbmaFixing. I don't like commented code personally.

@deeleeramone
Copy link
Contributor Author

This one is good. We need to align what is the best way to deal with the LbmaFixing. I don't like commented code personally.

Should we just remove entirely then? I can replace with the direct source eventually, like I did with SP500 multiples and COT reports.

@IgorWounds
Copy link
Contributor

This one is good. We need to align what is the best way to deal with the LbmaFixing. I don't like commented code personally.

Should we just remove entirely then? I can replace with the direct source eventually, like I did with SP500 multiples and COT reports.

Tagging @minhhoang1023 here.

@piiq
Copy link
Contributor

piiq commented Sep 23, 2024

@deeleeramone do you want to pick up the eia integration that's been done here https://github.com/piiq/openbb-energy ?

@deeleeramone
Copy link
Contributor Author

@deeleeramone do you want to pick up the eia integration that's been done here https://github.com/piiq/openbb-energy ?

ya, but that's out-of-scope for this PR.

@minhhoang1023
Copy link
Contributor

looks good. One thing - do we want to follow the same structure with rest of the endpoints.

So instead of obb.commodity.spot_prices, making it obb.commodity.price.spot

@deeleeramone
Copy link
Contributor Author

looks good. One thing - do we want to follow the same structure with rest of the endpoints.

So instead of obb.commodity.spot_prices, making it obb.commodity.price.spot

My only objection to that is that it's weird to have multiple levels where nothing else exists. TBH, I'm not sure if there will be more variants of prices here as futures exist elsewhere.

@deeleeramone deeleeramone enabled auto-merge October 3, 2024 17:57
@deeleeramone deeleeramone added this pull request to the merge queue Oct 3, 2024
Merged via the queue into develop with commit b9de848 Oct 3, 2024
10 checks passed
@deeleeramone deeleeramone deleted the feature/commodity-spot-prices branch October 3, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change enhancement Enhancement platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants