-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add EIA Daily Spot Prices Data via FRED #6677
Conversation
openbb_platform/extensions/commodity/integration/test_commodity_api.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is good. We need to align what is the best way to deal with the LbmaFixing. I don't like commented code personally.
Should we just remove entirely then? I can replace with the direct source eventually, like I did with SP500 multiples and COT reports. |
Tagging @minhhoang1023 here. |
@deeleeramone do you want to pick up the eia integration that's been done here https://github.com/piiq/openbb-energy ? |
ya, but that's out-of-scope for this PR. |
looks good. One thing - do we want to follow the same structure with rest of the endpoints. So instead of |
My only objection to that is that it's weird to have multiple levels where nothing else exists. TBH, I'm not sure if there will be more variants of prices here as futures exist elsewhere. |
Why?:
commodity
module.What?:
obb.commodity.spot_prices
lbma_fixing
endpoint from Nasdaq DataLink appears to be dead, commented out the fetcher and skipped those tests.Impact:
openbb-commodity
will populate with a function without installing any extras.Testing Done: