Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix Tests & Related Bugs #6657

Merged
merged 8 commits into from
Sep 6, 2024
Merged

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • Fixes for failing tests.
  2. What?:

    • Some test parameters needed to be adjusted.
    • Masks additional items in the test cassettes from openbb-cftc.
    • Fixes URL encoding of commas in SeekingAlpha and wraps the request(s) within a ClientSession object that is shared with subprocesses. This should fix unreliable connections to equity.estimates.forward_eps and forward_sales.
    • Fixes interactive tables in openbb-charting, and openbb-cli, where cells containing arrays result in no table being rendered in a white window.
      • Reference point for this is, obb.news.world
    • Fixes empty data being returned from openbb-intrinio, with, equity.calendar.ipo
  3. Impact:

    • Improved reliability.
  4. Testing Done:

    • I have run the comprehensive test suite locally.

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform labels Sep 6, 2024
@github-actions github-actions bot added the v4 PRs for v4 label Sep 6, 2024
Copy link
Contributor

@IgorWounds IgorWounds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd edit the start and end dates and re-record the cassettes.

@deeleeramone
Copy link
Contributor Author

I'd edit the start and end dates and re-record the cassettes.

These are integration tests, no cassettes here.

@deeleeramone deeleeramone dismissed IgorWounds’s stale review September 6, 2024 22:29

Integration tests are not cassette-based.

@deeleeramone deeleeramone added this pull request to the merge queue Sep 6, 2024
Merged via the queue into develop with commit f7196e8 Sep 6, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/pre-release-fixes branch September 26, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants