Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix CLI Interactive Tables Not Opening #6588

Merged
merged 3 commits into from
Jul 17, 2024
Merged

[BugFix] Fix CLI Interactive Tables Not Opening #6588

merged 3 commits into from
Jul 17, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

  2. What?:

    • Assigns a started Backend in the Session Singleton init.
    • Only use print_rich_table if not USE_INTERACTIVE_DF

  3. Impact:

    • Tables opening again.
    • Takes care of a couple Pandas Future Warnings.

  4. Testing Done:

    • Interactive On/Off
      • Using new commands and results.

@deeleeramone deeleeramone added bug Fix bug cli OpenBB Platform CLI labels Jul 15, 2024
hjoaquim
hjoaquim approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@hjoaquim hjoaquim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly. Interactive tables are back!

@deeleeramone deeleeramone added this pull request to the merge queue Jul 17, 2024
Merged via the queue into develop with commit 504b69f Jul 17, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/fix-cli-interactive-tables branch July 18, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoaquim hjoaquim hjoaquim approved these changes

Assignees
No one assigned
Labels
bug Fix bug cli OpenBB Platform CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] [CLI] Interactive Tables Not Working
2 participants
@deeleeramone @hjoaquim