Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Clean Up Nominal GDP & Add EconDB As Provider #6581

Merged
merged 7 commits into from
Jul 13, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • OECD was downloading unnecessary data that contributed significantly to a slow response time and wasted memory.

    • Additional providers can be added.

  2. What?:

    • Refactor request to download only requested countries, as data-only, from OECD.
    • Reconfigure OECD params as: frequency, units, price_base.
    • No additional params for EconDB, but real growth metrics (yoy/qoq) are included in the response.
    • Multiple items allowed for country.
    • All GDP values (not units = index) are in $USD, have been expanded to their full length, and are directly comparable between countries.
  3. Impact:

    • Improved response time.
    • "units" param is now: ["level", "index", "capita"]
    • EconDB added as provider to economy.gdp.nominal
  4. Testing Done:

    • Integration/Unit tests.

There are notable differences in the values returned from OECD vs. EconDB, factors related to OECD's applied normalization and annualized transformation. The results from EconDB more closely resemble other sites' "GDP by Country" rankings.

Screenshot 2024-07-12 at 10 03 10 AM

@deeleeramone deeleeramone added bug Fix bug enhancement Enhancement platform OpenBB Platform v4 PRs for v4 labels Jul 12, 2024
@deeleeramone deeleeramone requested a review from IgorWounds July 12, 2024 17:09
@IgorWounds IgorWounds added this pull request to the merge queue Jul 13, 2024
Merged via the queue into develop with commit 017ce1c Jul 13, 2024
10 checks passed
@IgorWounds IgorWounds deleted the bugfix/nominal-gdp branch July 13, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change bug Fix bug enhancement Enhancement platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants