Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Improvements to handling charts on the CLI results #6544

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

hjoaquim
Copy link
Contributor

  1. Why? (1-3 sentences or a bullet point list):

    • Better handling of charts and its fallback.
  2. What? (1-3 sentences or a bullet point list):

    • Use OBBject.charting.to_chart() as fallback
    • Enables the usage of charting arguments
  3. Impact (1-2 sentences or a bullet point list):

    • Minor UX improvement.
  4. Testing Done:

    • Run through several scenarios of using results (with key/index, with or without chart argument, with or without previously computed charts)
  5. Reviewer Notes (optional):

    • Using indicators on the CLI:

image

@hjoaquim hjoaquim requested a review from IgorWounds June 26, 2024 12:34
@github-actions github-actions bot added the enhancement Enhancement label Jun 26, 2024
@hjoaquim
Copy link
Contributor Author

@deeleeramone you'll like this one

@hjoaquim hjoaquim added this pull request to the merge queue Jun 26, 2024
Merged via the queue into develop with commit 5e69ce3 Jun 26, 2024
9 checks passed
@hjoaquim hjoaquim deleted the feature/to-chart-results branch June 26, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants