-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] - Add derivates historical chart #6520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is in the same category of issue as the Technical router integration tests. Perhaps satisfying issues in one place opened a new one elsewhere?
The code seems to work as expected, but there's an unrelated issue with the communication between some of the internal elements. An unexpected structure or object has been encountered.
@hjoaquim, something weird is happening here, It is mapping correctly in
In [2]: data = obb.derivatives.futures.historical("ES", chart=True)
In [3]: data
Out[3]:
OBBject
id: 0667486f-2c9e-700d-8000-6d8b77eeb5d9
results: [{'date': datetime.datetime(2000, 9, 18, 0, 0), 'open': 1485.25, 'high': 1...
provider: yfinance
warnings: [{'category': 'OpenBBWarning', 'message': "Parameter 'chart' not found."}...
chart: None
extra: {'metadata': {'arguments': {'provider_choices': {'provider': 'yfinance'}, 's... |
Not sure what happened here, but I had uninstalled both Now I got a weird glitch: Screen.Recording.2024-06-20.at.1.43.55.PM.movThis is a separate issue than the PR, the implementation of the execution seems fine. |
That's new 😲 |
Probably related to some kind of broken syntax in the |
@deeleeramone @hjoaquim are there updates regarding the charting? How should I proceed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix the tests and this is good to go; the fact that the charting is now modular makes this look so good and clean!
Why? (1-3 sentences or a bullet point list):
What? (1-3 sentences or a bullet point list):
price_historical
charting function to the futures derivatives price data.Impact (1-2 sentences or a bullet point list):
Testing Done: