Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue in earnings transcript not allowing FY 2025 to be retrieved #6500

Merged
merged 25 commits into from
Jun 14, 2024

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Jun 13, 2024

Change validate to if v < current_year + 1.

Before:

would map FY 2025 -> 2024 (NVDA)

After:
allows 2025

@github-actions github-actions bot added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Jun 13, 2024
Copy link
Contributor

@tehcoderer tehcoderer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deeleeramone
Copy link
Contributor

Multiple Items Allowed added for both 'symbol' and 'year'

Screenshot 2024-06-13 at 5 11 59 PM

@montezdesousa montezdesousa added this pull request to the merge queue Jun 14, 2024
Merged via the queue into develop with commit 3db89da Jun 14, 2024
9 checks passed
@IgorWounds IgorWounds deleted the hotfix/earnings-date branch June 16, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants