Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Generate settings menu from pydantic model #6489

Merged
merged 5 commits into from
Jun 12, 2024
Merged

[Feature] Generate settings menu from pydantic model #6489

merged 5 commits into from
Jun 12, 2024

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Jun 6, 2024 •
edited
Loading

Why?

Settings menu becomes out of sync with settings model

What?

  • Generate settings menu from model
  • Includes datetime preference to remove date and time from the flair

Impact:

NA

Testing Done:

  • Change settings, feature flags and preferences

@github-actions github-actions bot added the enhancement Enhancement label Jun 6, 2024
@montezdesousa montezdesousa marked this pull request as ready for review June 6, 2024 20:16
@montezdesousa montezdesousa added the cli OpenBB Platform CLI label Jun 6, 2024
@montezdesousa montezdesousa changed the title Generate settings menu from pydantic model [Feature] Generate settings menu from pydantic model Jun 6, 2024
@montezdesousa montezdesousa marked this pull request as draft June 6, 2024 20:18
@montezdesousa montezdesousa marked this pull request as ready for review June 7, 2024 10:53
@hjoaquim hjoaquim added this pull request to the merge queue Jun 12, 2024
Merged via the queue into develop with commit 174f289 Jun 12, 2024
9 checks passed
@montezdesousa montezdesousa deleted the feature/generate-cli-settings branch June 12, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoaquim hjoaquim hjoaquim approved these changes

Assignees
No one assigned
Labels
cli OpenBB Platform CLI enhancement Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@montezdesousa @hjoaquim