Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] CLI logging #6487

Merged
merged 4 commits into from
Jun 7, 2024
Merged

[Feature] CLI logging #6487

merged 4 commits into from
Jun 7, 2024

Conversation

hjoaquim
Copy link
Contributor

@hjoaquim hjoaquim commented Jun 6, 2024

  1. Why? (1-3 sentences or a bullet point list):

    • Adding proper CLI logging so we can know which users and how they're using it.
  2. What? (1-3 sentences or a bullet point list):

    • Adds cli to the system settings logging sub app Literal
    • Write cli to the logging sub app prop on the system settings file and then resets it to the original state after the CLI is closed
  3. Impact (1-2 sentences or a bullet point list):

    • NA
  4. Testing Done:

    • While using the CLI, cat the system_settings.json file to ensure it has changed
    • After closing/exception o the CLI verify it return to its original state (defaults to python)

@hjoaquim hjoaquim added the cli OpenBB Platform CLI label Jun 6, 2024
@github-actions github-actions bot added enhancement Enhancement platform OpenBB Platform v4 PRs for v4 labels Jun 6, 2024
@montezdesousa montezdesousa added this pull request to the merge queue Jun 7, 2024
Merged via the queue into develop with commit aa7bccc Jun 7, 2024
12 checks passed
@hjoaquim hjoaquim deleted the feature/cli-logging branch June 7, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli OpenBB Platform CLI enhancement Enhancement platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants