Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Remove svg export #6476

Merged
merged 10 commits into from
Jun 3, 2024
Merged

[Bugfix] Remove svg export #6476

merged 10 commits into from
Jun 3, 2024

Conversation

hjoaquim
Copy link
Contributor

@hjoaquim hjoaquim commented Jun 3, 2024

  1. Why? (1-3 sentences or a bullet point list):

    • Broken export to svg functionality.
  2. What? (1-3 sentences or a bullet point list):

    • Remove svg functionality.
  3. Impact (1-2 sentences or a bullet point list):

    • Minor UX: user won't be able to export to svg (that option will not be there) - but it wasn't working properly anyway.
  4. Testing Done:

    • Running the CLI and exporting to other formats.
  5. Reviewer Notes (optional):

    • Took the opportunity to clean up unused methods and improve linting.
    • Also added the url method to the charting extension (since the functionality existed already but was not exposed).
    • Also fixed the VERSION of the CLI, which was static.

@hjoaquim hjoaquim requested a review from IgorWounds June 3, 2024 09:59
@github-actions github-actions bot added bug Fix bug platform OpenBB Platform v4 PRs for v4 labels Jun 3, 2024
@IgorWounds IgorWounds added this pull request to the merge queue Jun 3, 2024
Merged via the queue into develop with commit 8a63c2d Jun 3, 2024
12 checks passed
@IgorWounds IgorWounds deleted the bugfix/fix-svg branch June 16, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants