Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix Empty Build Fail #6462

Merged
merged 4 commits into from
May 27, 2024
Merged

[BugFix] Fix Empty Build Fail #6462

merged 4 commits into from
May 27, 2024

Conversation

deeleeramone
Copy link
Contributor

@deeleeramone deeleeramone commented May 24, 2024

  1. Why?:

    • When no core router or provider components are installed, the app fails to build.
    "paths": ReferenceGenerator.get_paths(self.route_map),
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/danglewood/miniconda3/miniconda3/envs/empty/lib/python3.11/site-packages/openbb_core/app/static/package_builder.py", line 1731, in get_paths
    providers = provider_parameter_fields["type"]
                ^^^^^^^^^^^^^^^^^^^^^^^^^
UnboundLocalError: cannot access local variable 'provider_parameter_fields' where it is not associated with a value
  1. What?:

    • Initializing provider_parameter_fields in the lines above resolves the issue and an app with no router or provider extensions can be successfully built and initialized.
  2. Impact:

    • Easier to build minimal and custom configurations.
  3. Testing Done:

    • Create a router extension with openbb-core as the dependency.
    • New environment with no other components.

After:

Screenshot 2024-05-23 at 11 41 57 PM

Screenshot 2024-05-23 at 11 40 32 PM

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform labels May 24, 2024
@github-actions github-actions bot added the v4 PRs for v4 label May 24, 2024
@deeleeramone
Copy link
Contributor Author

deeleeramone commented May 24, 2024

#6458 ? Codespell is tripping out in unrelated files.

@IgorWounds IgorWounds requested a review from montezdesousa May 25, 2024 11:28
@IgorWounds IgorWounds added this pull request to the merge queue May 27, 2024
Merged via the queue into develop with commit bfad015 May 27, 2024
9 checks passed
@IgorWounds IgorWounds deleted the bugfix/fix-empty-build branch May 30, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants