Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix Seeking Alpha #6461

Merged
merged 6 commits into from
May 25, 2024
Merged

[BugFix] Fix Seeking Alpha #6461

merged 6 commits into from
May 25, 2024

Conversation

deeleeramone
Copy link
Contributor

@deeleeramone deeleeramone commented May 23, 2024

  1. Why?:

    • This fixes the implementation of Seeking Alpha endpoints.
  2. What?:

    • Delete "Upcoming Release Days" because this is actually the earnings calendar.
    • Add Forward EPS and Forward Sales estimates.
    • Support for US and Canadian markets for all 3 functions.
      • Canadian symbols are entered as the country composite ticker, "SHOP:CA".
      • Canadian earnings calendar is selected with the country parameter.
  3. Impact:

    • Minimal impact, no changes to any core component.
    • The removed endpoint from discovery is only occupied by this provider and it has always been problematic.
  4. Testing Done:

    • Integration and Unit tests.
    • Mix of symbols
    • Check calendar for both US and Canada.
    • CLI

Screenshot 2024-05-23 at 10 39 18 AM

Screenshot 2024-05-23 at 10 54 25 AM

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform labels May 23, 2024
@IgorWounds IgorWounds added this pull request to the merge queue May 25, 2024
Merged via the queue into develop with commit 5ff4d89 May 25, 2024
9 checks passed
@IgorWounds IgorWounds deleted the bugfix/seeking-alpha branch May 25, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants