Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Do Intrinio News TO-DOs -> Remove workaround because they fixed it. #6427

Merged
merged 3 commits into from
May 17, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • Intrinio news endpoints had a bug on their side that has now been resolved, this PR removes the workaround that was in place.
  2. What?:

    • The page_size parameter was breaking their API and needed to be a specific number, so it was taken out of the pipeline. This restores the limit parameter to work normally.
  3. Impact:

    • Better request fetching because pagination for 1 day of stories at 20-per-page is no longer required.
  4. Testing Done:

    • CompanyNews/WorldNews
  5. Reviewer Notes (optional):

    • testing with start/end dates is better when source=yahoo.

@deeleeramone deeleeramone added bug Fix bug platform OpenBB Platform labels May 16, 2024
@github-actions github-actions bot added the v4 PRs for v4 label May 16, 2024
@deeleeramone deeleeramone requested a review from IgorWounds May 16, 2024 20:15
@IgorWounds IgorWounds enabled auto-merge May 17, 2024 12:48
@IgorWounds IgorWounds added this pull request to the merge queue May 17, 2024
Merged via the queue into develop with commit 3df4e05 May 17, 2024
9 checks passed
@IgorWounds IgorWounds deleted the bugfix/update-intrinio-news branch May 20, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants