Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Remove i18n #6390

Merged
merged 3 commits into from
May 10, 2024
Merged

[Feature] Remove i18n #6390

merged 3 commits into from
May 10, 2024

Conversation

hjoaquim
Copy link
Contributor

  1. Why? (1-3 sentences or a bullet point list):

    • We're not using it.

  2. What? (1-3 sentences or a bullet point list):

    • Removed i18n and necessary adjustments so that descriptions are kept.

  3. Impact (1-2 sentences or a bullet point list):

    • NA / UX stays the same, anything should change.

  4. Testing Done:

    • Run the CLI and check commands/menus descriptions

@hjoaquim hjoaquim requested a review from IgorWounds May 10, 2024 16:07
@github-actions github-actions bot added the enhancement Enhancement label May 10, 2024
@hjoaquim hjoaquim added cli OpenBB Platform CLI and removed enhancement Enhancement labels May 10, 2024
@github-actions github-actions bot added the enhancement Enhancement label May 10, 2024
@montezdesousa montezdesousa self-requested a review May 10, 2024 19:08
@IgorWounds IgorWounds added this pull request to the merge queue May 10, 2024
Merged via the queue into develop with commit ac745ad May 10, 2024
7 checks passed
@hjoaquim hjoaquim deleted the feature/remove-i18n branch May 13, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montezdesousa montezdesousa montezdesousa approved these changes

@IgorWounds IgorWounds IgorWounds approved these changes

Assignees
No one assigned
Labels
cli OpenBB Platform CLI enhancement Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hjoaquim @IgorWounds @montezdesousa