Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Improve OBBject Registry #6364

Merged
merged 14 commits into from
May 6, 2024
Merged

Conversation

hjoaquim
Copy link
Contributor

@hjoaquim hjoaquim commented May 3, 2024

  1. Why? (1-3 sentences or a bullet point list):

    • Improve user experience by avoiding unnecessary confusion around the results command.
  2. What? (1-3 sentences or a bullet point list):

    • results as a global command, available everywhere
    • help message on results
    • newly created OBBjects immediately available after creation
    • the obbject registry is now an instance of the session instead of a singleton
    • added flag to control number of obbject results to keep
    • added flag to control if the user wants to know when a new obbject result was added
  3. Impact (1-2 sentences or a bullet point list):

    • NA / better UX
  4. Testing Done:

    • Run a set of commands and access the results.

@hjoaquim hjoaquim added the cli OpenBB Platform CLI label May 3, 2024
@hjoaquim hjoaquim requested a review from montezdesousa May 3, 2024 17:42
@github-actions github-actions bot added enhancement Enhancement labels May 3, 2024
@montezdesousa
Copy link
Contributor

The OBBject message goes a bit unnoticed, I'd move it next to the remaining warnings about columns and --export.

Screenshot 2024-05-06 at 11 42 36

@montezdesousa montezdesousa self-requested a review May 6, 2024 10:46
Copy link
Contributor

@montezdesousa montezdesousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting AttributeError: 'Namespace' object has no attribute 'columns' when running

/settings/ $ obbject_res -n 1

@hjoaquim
Copy link
Contributor Author

hjoaquim commented May 6, 2024

I'm getting AttributeError: 'Namespace' object has no attribute 'columns' when running

/settings/ $ obbject_res -n 1

typo fixed here: 66a6cea

@hjoaquim
Copy link
Contributor Author

hjoaquim commented May 6, 2024

The OBBject message goes a bit unnoticed, I'd move it next to the remaining warnings about columns and --export.

Addressed here: 06184de

@hjoaquim hjoaquim enabled auto-merge May 6, 2024 14:48
@hjoaquim hjoaquim added this pull request to the merge queue May 6, 2024
Merged via the queue into develop with commit 380891d May 6, 2024
7 checks passed
@piiq piiq deleted the feature/refactor-obbject-registry branch May 7, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli OpenBB Platform CLI enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants