Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] SEC ETF Holdings - Try Catch for RemoteDisconnect Error #6359

Merged
merged 4 commits into from
May 6, 2024

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

This is an attempt to mitigate a RemoteDisconnect error which can occasionally get raised from an SEC search query. In the handful of times I have encountered, the next request is successful.

image

  1. What? (1-3 sentences or a bullet point list):

    • Implement up-to 3 retries with a one-second sleep. If a retry is successful, a warning will be set as a notification.

    • Example: "Updated the risk calculation algorithm to factor in real-time market fluctuations."

  2. Impact (1-2 sentences or a bullet point list):

    • This may extend the timeout period, but if a response cannot be read within a couple of seconds, there is likely a network error.
  3. Testing Done:

    • Extremely hard to recreate, @montezdesousa, are you able to reliably reproduce and/or does this resolve?

@deeleeramone deeleeramone added bug Fix bug v4 PRs for v4 labels May 2, 2024
@deeleeramone deeleeramone requested a review from montezdesousa May 2, 2024 01:45
@github-actions github-actions bot added platform OpenBB Platform labels May 2, 2024
Copy link
Contributor

@montezdesousa montezdesousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot reproduce, but changes lgtm

@IgorWounds IgorWounds added this pull request to the merge queue May 6, 2024
Merged via the queue into develop with commit ec7ff94 May 6, 2024
10 checks passed
@piiq piiq deleted the bugfix/sec-remote-disconnect branch May 7, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants