Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Filtered provider arguments #6348

Merged
merged 2 commits into from
Apr 29, 2024
Merged

[BugFix] Filtered provider arguments #6348

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bc88cc
provider parameters were being removed bc not in signature
hjoaquim Apr 29, 2024
3b6208d
Merge branch 'develop' into bugfix/provider-parameters
IgorWounds Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions openbb_terminal/openbb_terminal/argparse_translator/argparse_translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ def __init__(
self.func = func
self.signature = inspect.signature(func)
self.type_hints = get_type_hints(func)
self.provider_parameters = []

self._parser = argparse.ArgumentParser(
prog=func.__name__,
Expand All @@ -221,6 +222,7 @@ def __init__(
# If the argument is already in use, we can't repeat it
if f"--{argument.name}" not in self._parser_arguments():
argparse_group.add_argument(f"--{argument.name}", **kwargs)
self.provider_parameters.append(argument.name)

def _parser_arguments(self) -> List[str]:
"""Get all the arguments from all groups currently defined on the parser."""
Expand Down Expand Up @@ -495,11 +497,11 @@ def execute_func(
kwargs = self._unflatten_args(vars(parsed_args))
kwargs = self._update_with_custom_types(kwargs)

# remove kwargs that doesn't match the signature
# remove kwargs that doesn't match the signature or provider parameters
kwargs = {
key: value
for key, value in kwargs.items()
if key in self.signature.parameters
if key in self.signature.parameters or key in self.provider_parameters
}

return self.func(**kwargs)
Expand Down
Loading