Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding OECD Endpoints (CPI + Share Price Index) #6157

Merged
merged 45 commits into from
May 29, 2024
Merged

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Mar 1, 2024

  1. Why?:

    • Expand macroeconomic data and provider coverage.
  • CPI
  • Share Price Index
  1. What?:

    • Added CPI from oecd which doesn't require an api key - but the input parameters are a bit more confusing. Nothing like 29 possible expenditures.
    • Edited the standard model
    • Expanded cpi -> consumer_price_index in files
    • Added share_price_index standard model and Economy route.
  2. Impact :

    • I did change the standard model to be compatible between fred + oecd, but the default values should work.
    • New standard model and provider endpoint to maintain.
  3. Testing Done:

    • Unit/Integration tests.
    • CLI
    • Various combinations of countries.

@github-actions github-actions bot added enhancement Enhancement platform OpenBB Platform v4 PRs for v4 labels Mar 1, 2024
@jmaslek jmaslek force-pushed the feature/oecd-cpi branch from 7598ec4 to 2928da1 Compare March 1, 2024 21:30
@deeleeramone deeleeramone changed the title Adding OECD endpoints Adding OECD CPI endpoints May 28, 2024
@deeleeramone
Copy link
Contributor

deeleeramone commented May 28, 2024

I have formatted the two providers to be uniform, and added unit/integration tests.

Screenshot 2024-05-28 at 11 19 43 AM

I have also added the Share Price Index:

Screenshot 2024-05-28 at 4 12 26 PM

@deeleeramone deeleeramone requested a review from IgorWounds May 28, 2024 18:23
@deeleeramone deeleeramone changed the title Adding OECD CPI endpoints Adding OECD Endpoints (CPI + Share Price Index) May 28, 2024
Copy link
Contributor

@IgorWounds IgorWounds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@IgorWounds IgorWounds added this pull request to the merge queue May 29, 2024
Merged via the queue into develop with commit 919d5a6 May 29, 2024
9 checks passed
@IgorWounds IgorWounds deleted the feature/oecd-cpi branch May 30, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change enhancement Enhancement platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants