Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves the settings/userdata command, and upgrade ruff #5359

Merged
merged 22 commits into from
Aug 22, 2023
Merged

Improves the settings/userdata command, and upgrade ruff #5359

merged 22 commits into from
Aug 22, 2023

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Aug 21, 2023 •
edited
Loading

@montezdesousa it looks like current_user doesn't grab the variable, can you point me in the right direction to fixing this?

Also bumps ruff.

@colin99d colin99d added the do not merge Label to prevent pull request merge label Aug 21, 2023
@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Aug 21, 2023
@reviewpad reviewpad bot added feat M Medium T-Shirt size feature and removed feat S Small T-Shirt size Feature labels Aug 21, 2023
reviewpad[bot]
reviewpad bot suggested changes Aug 21, 2023
View reviewed changes
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poetry.lock file has been changed. Please update both requirements.txt and requirements-full.txt files

@reviewpad reviewpad bot added feat L Large T-Shirt size Feature and removed feat M Medium T-Shirt size feature labels Aug 22, 2023
reviewpad[bot]
reviewpad bot suggested changes Aug 22, 2023
View reviewed changes
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poetry.lock file has been changed. Please update both requirements.txt and requirements-full.txt files

@colin99d colin99d changed the title Improves the settings/userdata command Improves the settings/userdata command, and upgrade ruff Aug 22, 2023
@colin99d colin99d removed the do not merge Label to prevent pull request merge label Aug 22, 2023
@reviewpad reviewpad bot added feat XL Extra Large feature and removed feat L Large T-Shirt size Feature labels Aug 22, 2023
reviewpad[bot]
reviewpad bot suggested changes Aug 22, 2023
View reviewed changes
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poetry.lock file has been changed. Please update both requirements.txt and requirements-full.txt files

reviewpad[bot]
reviewpad bot suggested changes Aug 22, 2023
View reviewed changes
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poetry.lock file has been changed. Please update both requirements.txt and requirements-full.txt files

reviewpad[bot]
reviewpad bot suggested changes Aug 22, 2023
View reviewed changes
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poetry.lock file has been changed. Please update both requirements.txt and requirements-full.txt files

reviewpad[bot]
reviewpad bot suggested changes Aug 22, 2023
View reviewed changes
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poetry.lock file has been changed. Please update both requirements.txt and requirements-full.txt files

reviewpad[bot]
reviewpad bot suggested changes Aug 22, 2023
View reviewed changes
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poetry.lock file has been changed. Please update both requirements.txt and requirements-full.txt files

reviewpad[bot]
reviewpad bot suggested changes Aug 22, 2023
View reviewed changes
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poetry.lock file has been changed. Please update both requirements.txt and requirements-full.txt files

reviewpad[bot]
reviewpad bot suggested changes Aug 22, 2023
View reviewed changes
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poetry.lock file has been changed. Please update both requirements.txt and requirements-full.txt files

reviewpad[bot]
reviewpad bot suggested changes Aug 22, 2023
View reviewed changes
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poetry.lock file has been changed. Please update both requirements.txt and requirements-full.txt files

reviewpad[bot]
reviewpad bot suggested changes Aug 22, 2023
View reviewed changes
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poetry.lock file has been changed. Please update both requirements.txt and requirements-full.txt files

reviewpad[bot]
reviewpad bot suggested changes Aug 22, 2023
View reviewed changes
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poetry.lock file has been changed. Please update both requirements.txt and requirements-full.txt files

reviewpad[bot]
reviewpad bot suggested changes Aug 22, 2023
View reviewed changes
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poetry.lock file has been changed. Please update both requirements.txt and requirements-full.txt files

reviewpad[bot]
reviewpad bot previously requested changes Aug 22, 2023
View reviewed changes
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poetry.lock file has been changed. Please update both requirements.txt and requirements-full.txt files

@jmaslek jmaslek enabled auto-merge August 22, 2023 19:58
@jmaslek jmaslek added this pull request to the merge queue Aug 22, 2023
Merged via the queue into develop with commit 1ca7fd9 Aug 22, 2023
@colin99d colin99d deleted the hotfix/5323 branch August 23, 2023 00:45
the-praxs pushed a commit that referenced this pull request Sep 4, 2023
@colin99d @the-praxs
Improves the settings/userdata command, and upgrade ruff (#5359)
7015dae 
* Began the fax

* Bumped ruff

* Fixed a BUNCH of ruff errors

* Fixed a lot of ruff errors

* Simplify if statements

* Fixed black

* Updated some stuff

* Updated some stuff

* A lot more ruff fixes

* Added a fix

* Added a fix

* Fixed mypy

* Fixed some stuff

* Reverted one thing

* Small fix

* Small fix

* Small fix

* Added fix

* Added fix

* Update requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaslek jmaslek jmaslek approved these changes

@reviewpad reviewpad[bot] reviewpad[bot] left review comments

Assignees
No one assigned
Labels
feat XL Extra Large feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colin99d @jmaslek