Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix/fix-intrinio-load: #5188

Merged
merged 8 commits into from
Jul 5, 2023
Merged

hotfix/fix-intrinio-load: #5188

merged 8 commits into from
Jul 5, 2023

Conversation

deeleeramone
Copy link
Contributor

This PR applies a band-aid until a more complete solution can be introduced (#5186) . The column for "Adj Close" is redundant and should ultimately be removed because it is not a correct label in some cases. There should be an argument for unadjusted = True, and this would be activated for sources that do not provide adjusted historical prices.

Before:

Screenshot 2023-06-27 at 7 57 10 AM

After:

Screenshot 2023-06-27 at 7 58 44 AM

Before:

Screenshot 2023-06-27 at 8 04 50 AM

After:

Screenshot 2023-06-27 at 8 03 32 AM

@deeleeramone deeleeramone added the bug Fix bug label Jun 27, 2023
@deeleeramone deeleeramone requested a review from jmaslek June 27, 2023 15:06
@reviewpad reviewpad bot added the feat XS Extra small feature label Jun 27, 2023
@jmaslek jmaslek enabled auto-merge July 5, 2023 13:25
@jmaslek jmaslek added this pull request to the merge queue Jul 5, 2023
Merged via the queue into develop with commit 598e745 Jul 5, 2023
@piiq piiq deleted the hotfix/fix-intrinio-load branch July 12, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants