Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve stock ticker suffix #5056

Merged
merged 2 commits into from
May 22, 2023
Merged

Preserve stock ticker suffix #5056

merged 2 commits into from
May 22, 2023

Conversation

IgorWounds
Copy link
Contributor

This PR closes #4965 and adds a way to preserve the stock ticker suffix. Please double confirm that I didn't break other things :D

@IgorWounds IgorWounds added the bug Fix bug label May 22, 2023
@IgorWounds IgorWounds requested a review from deeleeramone May 22, 2023 12:45
@reviewpad reviewpad bot added the feat XS Extra small feature label May 22, 2023
@IgorWounds IgorWounds requested a review from jmaslek May 22, 2023 13:27
deeleeramone
deeleeramone requested changes May 22, 2023
View reviewed changes
Copy link
Contributor

@deeleeramone deeleeramone left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny quirk here where I enter the FA menu and the suffix is doubled.

Screenshot 2023-05-22 at 7 31 59 AM

(🦋) /stocks/fa/ $ income

Could not get data


(🦋) /stocks/fa/ $ income --ticker RY.TO

Screenshot 2023-05-22 at 7 34 32 AM

Same thing shows up in the CA menu:

Screenshot 2023-05-22 at 7 47 33 AM

@IgorWounds IgorWounds marked this pull request as draft May 22, 2023 16:00
@IgorWounds IgorWounds requested a review from deeleeramone May 22, 2023 16:20
deeleeramone
deeleeramone approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@deeleeramone deeleeramone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised.

@IgorWounds IgorWounds marked this pull request as ready for review May 22, 2023 18:56
@IgorWounds IgorWounds added this pull request to the merge queue May 22, 2023
Merged via the queue into develop with commit d748766 May 22, 2023
@IgorWounds IgorWounds deleted the hotfix/ticker-suffix-preserve branch May 22, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deeleeramone deeleeramone deeleeramone approved these changes

@jmaslek jmaslek Awaiting requested review from jmaslek

Assignees
No one assigned
Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Tickers are stripped of their suffix, then sources downstream fail or get the wrong symbol.
2 participants
@IgorWounds @deeleeramone