-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhances stocks/quote
to allow for multiple tickers
#4928
Conversation
@jmaslek, any idea why running |
not sure. Probably something with formatting. Surprised black didnt get rid of them. Did you have to manually get rid of them ? |
Yes, manually deleted them. |
You need to add some logic for if a string is added in. This will split it by letters
|
Done! Added a caveat:
btw, @jmaslek, every function with a list as an input currently does this. |
Description
This PR is for improving the
stocks/quote
command to allow for querying multiple tickers. The additional motivation for this change is to facilitate the ability to add watch list functionality.The SDK has been updated to include,
openbb.stocks.quote_chart()
, and the docstrings have been updated to reflect the changes to the syntax requiring the tickers to be entered as a list for the model and view.The Equity Report file has been updated to include the change in syntax to the SDK function.
Note: Additional
--source
will be included in a future PR to allow this command to operate without any API keys required.quote AAPL,META,MSFT,GOOG,NFLX,AMZN
The index strings are now formatted as a title.
How has this been tested?
Additional unit tests have been added capturing multiple tickers, and as well as the handling for a bad ticker.
pytest tests/openbb_terminal/stocks/test_stocks_helper.py
The integration test for the stocks menu has been updated to include multi-ticker quotes.
Checklist:
feature/feature-name
orhotfix/hotfix-name
.Others