Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alt & mutual fund unit test & cleanup #4540

Merged
merged 15 commits into from
Mar 23, 2023
Merged

Alt & mutual fund unit test & cleanup #4540

merged 15 commits into from
Mar 23, 2023

Conversation

IgorWounds
Copy link
Contributor

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@IgorWounds IgorWounds added the tests Test-related work label Mar 20, 2023
@reviewpad reviewpad bot added the feat XL Extra Large feature label Mar 20, 2023
@IgorWounds IgorWounds marked this pull request as draft March 23, 2023 12:03
@IgorWounds IgorWounds marked this pull request as ready for review March 23, 2023 12:23
Chavithra
Chavithra approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@Chavithra Chavithra added this pull request to the merge queue Mar 23, 2023
Merged via the queue into develop with commit 2bf1729 Mar 23, 2023
@IgorWounds IgorWounds deleted the feature/alt-funds-unit-tests branch April 1, 2023 20:08
jmaslek added a commit that referenced this pull request Apr 13, 2023
@IgorWounds @jmaslek @montezdesousa
Alt & mutual fund unit test & cleanup (#4540)
bd0299b 
* Alternative & Mutual Funds unit tests & cleanup

* ruff

* add dependency

* general linting updates

* Update reqs

* pytest-recorder updates

* pre-commit config

* checkout dependencies from develop

* dependency update

* dependency update

* pytest-recorder updates

---------

Co-authored-by: James Maslek <[email protected]>
Co-authored-by: montezdesousa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chavithra Chavithra Chavithra approved these changes

@montezdesousa montezdesousa Awaiting requested review from montezdesousa

@jmaslek jmaslek Awaiting requested review from jmaslek

Assignees
No one assigned
Labels
feat XL Extra Large feature tests Test-related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IgorWounds @Chavithra @jmaslek @montezdesousa