Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/fred #4493

Merged
merged 4 commits into from
Mar 15, 2023
Merged

Hotfix/fred #4493

merged 4 commits into from
Mar 15, 2023

Conversation

colin99d
Copy link
Contributor

Description

Improves the handling of query and parameter arguments.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label Mar 15, 2023
@colin99d
Copy link
Contributor Author

I dont think these tests are failing because of me...

@jmaslek
Copy link
Collaborator

jmaslek commented Mar 15, 2023

I dont think these tests are failing because of me...

=========================== short test summary info ============================
FAILED tests/openbb_terminal/economy/test_economy_controller.py::test_call_fred_params[other_args0-fred_view.display_fred_series-called_args0-called_kwargs0]
FAILED tests/openbb_terminal/economy/test_economy_controller.py::test_call_fred_params[other_args1-fred_view.display_fred_series-called_args1-called_kwargs1]
FAILED tests/openbb_terminal/economy/test_economy_controller.py::test_call_fred_params[other_args2-fred_view.display_fred_series-called_args2-called_kwargs2]

Something changed in the function call lol

@jmaslek jmaslek enabled auto-merge March 15, 2023 20:15
@jmaslek jmaslek added this pull request to the merge queue Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@b19dc52). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4493   +/-   ##
==========================================
  Coverage           ?   54.53%           
==========================================
  Files              ?      596           
  Lines              ?    53482           
  Branches           ?        0           
==========================================
  Hits               ?    29164           
  Misses             ?    24318           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Merged via the queue into develop with commit 6581868 Mar 15, 2023
@colin99d colin99d deleted the hotfix/fred branch March 17, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants