Change SessionId
to uuid-like format
#4476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^
Benefit of having the SessionId as a UUID instead of the UNIX timestamp: avoid having users with the same UserId/AppId with the same SessionId - this would happen in the case of the user launching two terminal instances exactly at the same time.
Side effect: log files names change from
gst_1678795847.2023-03-14_12.log
togst_5b698cdc-4d4d-4b2f-983a-2660cba0ea97-1678795471.2023-03-14_12.log
- this comes with no other consequences, since for the logging etl we're filtering those files usingLastModified
S3 param.