Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK_README.md #4461

Conversation

FriendlyUser
Copy link
Contributor

Description

  • Fix typo in SDK_README.md

I looked and looked through the openbb documentation, on the website it suggests using openbb[all] to install all dependencies, think this documentation bug was overlooked.

How has this been tested?

Documentation change, should require no testing.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label Mar 12, 2023
Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catches!

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@c7e6285). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #4461   +/-   ##
==========================================
  Coverage           ?   54.72%           
==========================================
  Files              ?      596           
  Lines              ?    53638           
  Branches           ?        0           
==========================================
  Hits               ?    29354           
  Misses             ?    24284           
  Partials           ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmaslek jmaslek added this pull request to the merge queue Mar 12, 2023
Merged via the queue into OpenBB-finance:develop with commit cbdf336 Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants