Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix/economy-charts #4387

Merged
merged 10 commits into from
Mar 3, 2023

Conversation

tehcoderer
Copy link
Contributor

@tehcoderer tehcoderer commented Mar 2, 2023

#4376 #4375

Fix null values in economy charts that made them go cray

Before
image

After
image

New Pywry version to override in-window downloads with USER_EXPORTS_DIRECTORY path

Before
image

After
image

Fixed rare instances CHART_DIV in main.js is undefined if pywry window loads too fast which resulted in no plot loading

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label Mar 2, 2023
@reviewpad reviewpad bot added feat M Medium T-Shirt size feature and removed feat XS Extra small feature labels Mar 2, 2023
@tehcoderer tehcoderer merged commit 94e2b33 into OpenBB-finance:develop Mar 3, 2023
jmaslek pushed a commit that referenced this pull request Apr 13, 2023
* fixes

* missing dropna on economy models, bump pywry version to override download path

* Update backend.py

* tests

* fix rare instance CHART_DIV is undefined if pywry window loads too fast

* add warning of pywry version due to json keys change

* pylint

* Update fred_view.py

* Update fred_view.py

* Update plotly_helper.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat M Medium T-Shirt size feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants