Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helper_classes.py bug on line 126 #4378

Merged
merged 5 commits into from
Mar 6, 2023
Merged

Update helper_classes.py bug on line 126 #4378

merged 5 commits into from
Mar 6, 2023

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Mar 2, 2023

I have not tested this fix, but the current code crashes when I make an installer from the SDK.

@reviewpad reviewpad bot added the feat XS Extra small feature label Mar 2, 2023
@jmaslek
Copy link
Collaborator

jmaslek commented Mar 2, 2023

branch name

@jmaslek jmaslek merged commit 324dcb7 into develop Mar 6, 2023
JerBouma pushed a commit that referenced this pull request Mar 6, 2023
JerBouma added a commit that referenced this pull request Mar 9, 2023
…quirements and more (#4382)

* fix: changed button styles

* Make Rosetta requirements more clear

* Update installation instructions

* Add seperation

* Update windows.md

* Update installation docs

* fix country choices (#4403)

* Hotfix/plotsbackend start (#4404)

* readd removed plots_backend().start() from merged PR

* Update backend.py

---------

Co-authored-by: montezdesousa <[email protected]>

* Update helper_classes.py (#4378)

Co-authored-by: James Maslek <[email protected]>

* Add improvements to the website

* Fix keys wrong redirect

* Update installation

* Update requirements

* move things around

* Restructure everything

* Details

* fix: mac issue and redirect installation

* fix: mac macos

* Remove installation .md and make it dropdown

* Update installation of SDK

* Grammar

---------

Co-authored-by: Jeroen Bouma <[email protected]>
Co-authored-by: montezdesousa <[email protected]>
Co-authored-by: teh_coderer <[email protected]>
Co-authored-by: Colin Delahunty <[email protected]>
Co-authored-by: James Maslek <[email protected]>
@colin99d colin99d deleted the colin99d-patch-1 branch March 17, 2023 19:19
jmaslek added a commit that referenced this pull request Apr 13, 2023
…quirements and more (#4382)

* fix: changed button styles

* Make Rosetta requirements more clear

* Update installation instructions

* Add seperation

* Update windows.md

* Update installation docs

* fix country choices (#4403)

* Hotfix/plotsbackend start (#4404)

* readd removed plots_backend().start() from merged PR

* Update backend.py

---------

Co-authored-by: montezdesousa <[email protected]>

* Update helper_classes.py (#4378)

Co-authored-by: James Maslek <[email protected]>

* Add improvements to the website

* Fix keys wrong redirect

* Update installation

* Update requirements

* move things around

* Restructure everything

* Details

* fix: mac issue and redirect installation

* fix: mac macos

* Remove installation .md and make it dropdown

* Update installation of SDK

* Grammar

---------

Co-authored-by: Jeroen Bouma <[email protected]>
Co-authored-by: montezdesousa <[email protected]>
Co-authored-by: teh_coderer <[email protected]>
Co-authored-by: Colin Delahunty <[email protected]>
Co-authored-by: James Maslek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants