Update functionality with FinanceDatabase v2, depreciate stocks/sia, fix exe --example and fix stocks/fa/dcf

[JerBouma]

Description

Basically what changed in this new version of the FinanceDatabase is the following:

• Package itself is object orientated, needs initialisation (collect data first) but gets the job done in a much quicker fashion. For example a file with 180k tickers is loaded within 2 seconds and from there on everything is done locally and really quick.
• The Database itself is now CSV files meaning it is much easier to edit the files. No longer thousands of JSON files that have the same data multiple times.
• All files loaded into the package are compressed down versions of Pickles with compression method xz. It shrinks the original JSON file of 120mb to 10mb, see this file. Auto-updated with GitHub Actions.
• Querying is easier with .search using kwargs.
• Equities now follows GICS sectors, industry groups and industries.
• ETFs and Funds have their categories reduced and grouped. Furthermore, families (e.g. Vanguard) now is grouped better (there were 5 different versions of their name).
• Multiple corrections within the entire database.
• Revamp of the whole thing to entice people to help out and update (also given that the CSVs now exist). Whether this actually happens is of course yet to be seen.

For OpenBB Terminal this means:

• stocks/searchis faster.
• etf search functions are faster and updates are more frequent.
• stocks/sia is less buggy with less dependency on Yahoo Finance. However, this PR also retires this menu for the time being. This is because it's currently functionality is better resolved within stocks/ca and through routines.
• Some minor misc updates, making code more efficient and requiring far less calls to the web (specifically GitHub).
• Also fixed stocks/fa/dcf since it relied partly on FinanceDatabase so I extended that to replace Yahoo Finance functionality.

Fixes #4225

How has this been tested?

• Please describe the tests that you ran to verify your changes.
• Provide instructions so we can reproduce.
• Please also list any relevant details for your test configuration.

• Make sure affected commands still run in terminal
• Ensure the SDK still works
• Check any related reports

Checklist:

• I have adhered to the GitFlow naming convention and my branch name is in the format of feature/feature-name or hotfix/hotfix-name.
• Update our documentation following these guidelines. Update any user guides that are affected by the changes.
• Update our tests following these guidelines.
• Make sure you are following our CONTRIBUTING guidelines.
• If a feature was added make sure to add it to the corresponding integration test script.

Others

• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.

[JerBouma]

Done, not entirely sure what's with the infinity mark regarding files 😅

[hjoaquim]

@JerBouma did you use poetry to update financedatabase dependency?

[JerBouma]

@hjoaquim I didn't, it failed on me when I did that 😅

[hjoaquim]

Sorry to comment like this but, can't comment directly on VSCode:

• Is this function being used anywhere or we can deprecate it openbb_terminal.stocks.discovery.financedatabase_view.show_equities?
• On dcf_view is there a way to remove this yf.Ticker(symbol).fast_info (similarly to what was done for the info)?

[JerBouma]

Sorry to comment like this but, can't comment directly on VSCode:

• Is this function being used anywhere or we can deprecate it openbb_terminal.stocks.discovery.financedatabase_view.show_equities?
• On dcf_view is there a way to remove this yf.Ticker(symbol).fast_info (similarly to what was done for the info)?

First one is indeed not used. I just updated it for the sake of it. Within the dcf_view I actually believe that already has no value to begin with.

[JerBouma]

Just a headsup, this PR depreciates the stocks/sia menu from the OpenBB Terminal and deletes sia paths from the OpenBB SDK. Given that we do not maintain it anymore within the OpenBB Terminal for the time being it wouldn't make sense to keep it around in the OpenBB SDK. Furthermore, it also gets rid of the documentation pages related to it.

See: a9a27b6

[JerBouma]

Fixed the fact that it didn't actually search in short_name and the index properly. It does now with 7375b93 so you can do the following:

(🦋) /stocks/ $ search tsla --all-exchanges

                                                      Companies found on term tsla                                                      
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━┓
┃           ┃ Name                        ┃ Country       ┃ Sector                 ┃ Industry Group           ┃ Industry    ┃ Exchange ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━┩
│ TSLA-U.TI │ Tesla, Inc.                 │ United States │ Consumer Discretionary │ Automobiles & Components │ Automobiles │ TLO      │
├───────────┼─────────────────────────────┼───────────────┼────────────────────────┼──────────────────────────┼─────────────┼──────────┤
│ TSLA.BA   │ Tesla, Inc.                 │ United States │ Consumer Discretionary │ Automobiles & Components │ Automobiles │ BUE      │
├───────────┼─────────────────────────────┼───────────────┼────────────────────────┼──────────────────────────┼─────────────┼──────────┤
│ TSLA.MI   │ Tesla, Inc.                 │ United States │ Consumer Discretionary │ Automobiles & Components │ Automobiles │ MIL      │
├───────────┼─────────────────────────────┼───────────────┼────────────────────────┼──────────────────────────┼─────────────┼──────────┤
│ TSLA.MX   │ Tesla, Inc.                 │ United States │ Consumer Discretionary │ Automobiles & Components │ Automobiles │ MEX      │
├───────────┼─────────────────────────────┼───────────────┼────────────────────────┼──────────────────────────┼─────────────┼──────────┤
│ TSLA      │ Tesla, Inc.                 │ United States │ Consumer Discretionary │ Automobiles & Components │ Automobiles │ NMS      │
├───────────┼─────────────────────────────┼───────────────┼────────────────────────┼──────────────────────────┼─────────────┼──────────┤
│ TSLA.VI   │ Tesla, Inc.                 │ United States │ Consumer Discretionary │ Automobiles & Components │ Automobiles │ VIE      │
├───────────┼─────────────────────────────┼───────────────┼────────────────────────┼──────────────────────────┼─────────────┼──────────┤
│ TSLA34.SA │ Tesla, Inc.                 │ United States │ Consumer Discretionary │ Automobiles & Components │ Automobiles │ SAO      │
├───────────┼─────────────────────────────┼───────────────┼────────────────────────┼──────────────────────────┼─────────────┼──────────┤
│ TSLAC.BA  │ Tesla, Inc.                 │ United States │ Consumer Discretionary │ Automobiles & Components │ Automobiles │ BUE      │
├───────────┼─────────────────────────────┼───────────────┼────────────────────────┼──────────────────────────┼─────────────┼──────────┤
│ TSLAB.BA  │ Tesla, Inc.                 │ nan           │ Consumer Discretionary │ Automobiles & Components │ Automobiles │ nan      │
├───────────┼─────────────────────────────┼───────────────┼────────────────────────┼──────────────────────────┼─────────────┼──────────┤
│ JS3HN9.TI │ GSF BIDU/NIO/TSLA CC 310325 │ nan           │ nan                    │ nan                      │ nan         │ TLO      │
└───────────┴─────────────────────────────┴───────────────┴────────────────────────┴──────────────────────────┴─────────────┴──────────┘

[JerBouma]

Small fix here so that it doesn't crash if you have no ticker loaded.

@jmaslek Let me know if I need to give you a tour what I changed due to infinite files.

[jmaslek]

Small fix here so that it doesn't crash if you have no ticker loaded.

@jmaslek Let me know if I need to give you a tour what I changed due to infinite files.

found what infinite means to github:

[jmaslek]

etf/screener_controller can be deleted (with associated tests)

[jmaslek]

On stocks/load I am not getting autocomplete options with nay of the choices :(

[jmaslek]

On stocks/load I am not getting autocomplete options with nay of the choices :(

Related to this: when I go into stocks I get this message.

2023 Feb 25, 18:31 (🦋) / $ stocks

Note: Some datasets from GitHub failed to load. This means that the `search` command and the /stocks/sia menu will not work. If other commands are failing please check your internet connection or communicate with your IT department that certain websites are blocked.

Am at home. Have always done this from home. (Probably also want to get rid of the stocks/sia reference there)

[JerBouma]

You get that because you are not on the latest version of the package, v2.0.6. Thats also why no auto complete in search.

[jmaslek]

You get that because you are not on the latest version of the package, v2.0.6. Thats also why no auto complete in search.

Hm. Alright. Poetry install is giving 2.0.4 so we need to bump that.

[jmaslek]

You get that because you are not on the latest version of the package, v2.0.6. Thats also why no auto complete in search.

Hm. Alright. Poetry install is giving 2.0.4 so we need to bump that.

fixed

[JerBouma]

@jmaslek

Updated package to v2.0.7 (saw minor mistake in my own code) and removed etf/screener. Anything else before merge?

[jmaslek]

@jmaslek

Updated package to v2.0.7 (saw minor mistake in my own code) and removed etf/screener. Anything else before merge?

Just make sure tests are passing

[jmaslek]

small changes. lgtm