Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set query arg in economy/eval as required #4317

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Set query arg in economy/eval as required #4317

merged 2 commits into from
Feb 22, 2023

Conversation

elyanah-aco
Copy link
Contributor

Description

Closes #4238 by making the --query arg in economy/eval required. Bug was caused by ns_parser not being NoneType even if no argument was passed. Given that --query has no default value and is dependent on loaded data, it makes sense to require it.

How has this been tested?

  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label Feb 22, 2023
Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thinking!

@jmaslek jmaslek merged commit 2079649 into OpenBB-finance:develop Feb 22, 2023
@elyanah-aco elyanah-aco deleted the hotfix/economy-eval branch February 24, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] economy/eval Error: can only join an iterable
2 participants