Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for SIA menu #4294

Merged
merged 6 commits into from
Feb 20, 2023
Merged

Hotfix for SIA menu #4294

merged 6 commits into from
Feb 20, 2023

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Feb 20, 2023

I am not proud, but I found a yf alternative that seems to be stable-ish. This is like the cheap knock off brand of band aids that will work for a few minutes. But it works.

Fixes: #4283

@jmaslek jmaslek added the bug Fix bug label Feb 20, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label Feb 20, 2023
@JerBouma
Copy link
Contributor

Give me a moment to look if I can fix attrib with FMP.

@JerBouma
Copy link
Contributor

Fixed attrib and therefore also removed the message:
image

@JerBouma
Copy link
Contributor

Does the menu actually work? I get no company data on any of the functionalities.

image

@jmaslek
Copy link
Collaborator Author

jmaslek commented Feb 20, 2023

Does the menu actually work? I get no company data on any of the functionalities.

image

probably need to move away from stock analysis scraping.

@jmaslek
Copy link
Collaborator Author

jmaslek commented Feb 20, 2023

Give me a moment to look if I can fix attrib with FMP.

is this a free endpoint or will it throw an error with free tier?

@JerBouma
Copy link
Contributor

Give me a moment to look if I can fix attrib with FMP.

is this a free endpoint or will it throw an error with free tier?

Freeee

@JerBouma
Copy link
Contributor

Does the menu actually work? I get no company data on any of the functionalities.
image

probably need to move away from stock analysis scraping.

Agreed, could replace with FMP here too. But the other one is actually Yahoo Finance. In any case, plotting over multiple years is the only one that is actually insightful so it can go as well.

@jmaslek
Copy link
Collaborator Author

jmaslek commented Feb 20, 2023

Does the menu actually work? I get no company data on any of the functionalities.
image

probably need to move away from stock analysis scraping.

Agreed, could replace with FMP here too. But the other one is actually Yahoo Finance. In any case, plotting over multiple years is the only one that is actually insightful so it can go as well.

So thats out of the scope here, as this just addressd loading into the menu. Plz approve

Copy link
Contributor

@JerBouma JerBouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yush

@tehcoderer tehcoderer mentioned this pull request Feb 20, 2023
15 tasks
@jmaslek jmaslek merged commit 9af4dc0 into develop Feb 20, 2023
@jmaslek
Copy link
Collaborator Author

jmaslek commented Feb 20, 2023

@JerBouma wanna open a new issue for the stuff you mentioned?

@piiq piiq deleted the hotfix/sia branch February 20, 2023 18:42
@JerBouma
Copy link
Contributor

@JerBouma wanna open a new issue for the stuff you mentioned?

Done #4308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] openbb-stocks-sia fails with yfinance error
2 participants