Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests : mocking yfinance tzcache #4187

Merged
merged 4 commits into from
Feb 9, 2023
Merged

Tests : mocking yfinance tzcache #4187

merged 4 commits into from
Feb 9, 2023

Conversation

Chavithra
Copy link
Contributor

Description

Fixing yfinance tzcache issue on tests.

@Chavithra Chavithra requested a review from jmaslek February 9, 2023 16:26
@reviewpad reviewpad bot added the feat XS Extra small feature label Feb 9, 2023
jmaslek
jmaslek approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jmaslek jmaslek enabled auto-merge February 9, 2023 16:33
@reviewpad reviewpad bot added feat XL Extra Large feature and removed feat XS Extra small feature labels Feb 9, 2023
@jmaslek jmaslek added this pull request to the merge queue Feb 9, 2023
auto-merge was automatically disabled February 9, 2023 18:48

Merge queue setting changed

@jmaslek jmaslek removed this pull request from the merge queue due to the queue being cleared Feb 9, 2023
@jmaslek jmaslek merged commit 62b724d into OpenBB-finance:develop Feb 9, 2023
@Chavithra Chavithra deleted the feature/mocking_yfinance_tzcache branch February 9, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montezdesousa montezdesousa montezdesousa approved these changes

@jmaslek jmaslek jmaslek approved these changes

Assignees
No one assigned
Labels
feat XL Extra Large feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chavithra @jmaslek @montezdesousa