Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Last Price Bug into Previous Close #3865 #3908

Closed
wants to merge 0 commits into from
Closed

Fixing Last Price Bug into Previous Close #3865 #3908

wants to merge 0 commits into from

Conversation

Bonganibendi
Copy link
Contributor

  • I updated "Last Price" to "Previous Close" in the issue.

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label Jan 9, 2023
@jmaslek jmaslek changed the base branch from main to develop January 11, 2023 20:52
@jmaslek jmaslek changed the base branch from develop to main January 11, 2023 20:53
@jmaslek jmaslek changed the base branch from main to develop January 11, 2023 20:53
@jmaslek
Copy link
Collaborator

jmaslek commented Jan 11, 2023

Hey! Thanks for this! I just changed the base, so that this is merging into develop and not main. Not sure why some of these conflicts are occuring, but can you look at merging with develop?

@Bonganibendi
Copy link
Contributor Author

Hey! Thanks for this! I just changed the base, so that this is merging into develop and not main. Not sure why some of these conflicts are occuring, but can you look at merging with develop?

Hi, I will make a new pull request to the develop branch.

@Bonganibendi Bonganibendi deleted the fix_lastPrice_bug branch January 12, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants