Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stocks load (link #3699) #3700

Merged
merged 6 commits into from
Dec 5, 2022
Merged

Conversation

victortangggg
Copy link
Contributor

replace yfinance api call with stats to cut loading time

Description

Link #3699
bottleneck is yfinance's info api call. stats have the info and call is faster.
image

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

using debugger.

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

replace yfinance api call with stats to cut loading time
@DidierRLopes
Copy link
Collaborator

Thank you for this @victortangggg !! 🤝

Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much better! Thanks for bringing this method to our attention. We should replace this throughout!

@jmaslek jmaslek merged commit 15afc56 into OpenBB-finance:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants