Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for ETF export #3664

Merged
merged 6 commits into from
Nov 30, 2022
Merged

Bug fix for ETF export #3664

merged 6 commits into from
Nov 30, 2022

Conversation

victortangggg
Copy link
Contributor

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

fix bug for ETF export by using correct data type for parameters
Link #3654

image

How has this been tested?

manually

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

N/A

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Thanks

@jmaslek
Copy link
Collaborator

jmaslek commented Nov 30, 2022

Looks like the linter is failing. You can fix that by running black ./.

bug fix for etf search export
ran black to resolve lint issue during PR
@victortangggg
Copy link
Contributor Author

@jmaslek hey thanks for helping. I think the linting passes now! :)

@jmaslek jmaslek merged commit 32bfba4 into OpenBB-finance:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants