Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect date typing in signatures #3524

Merged
merged 11 commits into from
Nov 22, 2022
Merged

Fix incorrect date typing in signatures #3524

merged 11 commits into from
Nov 22, 2022

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Nov 22, 2022

openbb.economy.macro(start_date="2019-01-01", end_date="2019-12-31")
economy/macro -s 2019-01-01 -e 2019-12-31

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat M Medium T-Shirt size feature label Nov 22, 2022
@Chavithra Chavithra self-requested a review November 22, 2022 12:33
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@montezdesousa montezdesousa marked this pull request as ready for review November 22, 2022 13:40
@montezdesousa
Copy link
Contributor Author

Looks ok to me.

Looks ok to me.

Had to make some changes due to mypy

@jmaslek jmaslek merged commit bfc4c02 into main Nov 22, 2022
@jmaslek jmaslek deleted the date_typing branch November 22, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat M Medium T-Shirt size feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants