Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crypto/dd/eb in SDK #3523

Merged
merged 7 commits into from
Nov 22, 2022
Merged

Fix crypto/dd/eb in SDK #3523

merged 7 commits into from
Nov 22, 2022

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Nov 22, 2022 •
edited
Loading

Description

This PR fixes #3389

  • Adds a docstring example

Dataframes were not merged correctly.

SDK:
openbb.crypto.dd.eb(symbol="BTC")
openbb.crypto.dd.eb_chart(symbol="BTC")

Terminal:
crypto/load ETH
dd/eb

@montezdesousa montezdesousa added bug Fix bug platform OpenBB Platform labels Nov 22, 2022
@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Nov 22, 2022
@montezdesousa montezdesousa changed the title Crypto eb Fix crypto/dd/eb in SDK Nov 22, 2022
@reviewpad reviewpad bot added the feat XS Extra small feature label Nov 22, 2022
Chavithra
Chavithra reviewed Nov 22, 2022
View reviewed changes
openbb_terminal/cryptocurrency/due_diligence/glassnode_view.py Outdated
exchange: str = "binance",
start_date: str = "2010-01-01",
exchange: str = "aggregated",
start_date: str = None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right typing

@Chavithra Chavithra self-requested a review November 22, 2022 11:39
Chavithra
Chavithra approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@Chavithra Chavithra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Both commands and sdk functions are working on my side.

Please fix the typing.

@jmaslek jmaslek merged commit 714e7f2 into main Nov 22, 2022
@jmaslek jmaslek deleted the crypto_eb branch November 22, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chavithra Chavithra Chavithra approved these changes

Assignees
No one assigned
Labels
bug Fix bug feat S Small T-Shirt size Feature feat XS Extra small feature platform OpenBB Platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] SDK - openbb.crypto.dd.eb endpoint is not working
3 participants
@montezdesousa @Chavithra @jmaslek