Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing various bugs #3474

Merged
merged 11 commits into from
Nov 18, 2022
Merged

Fixing various bugs #3474

merged 11 commits into from
Nov 18, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Nov 18, 2022

Description

Fixes #3471
Fixes #3469
Fixes #3466
Fixes #3465

Ended up refactoring the screener menu to match how we do things elsewhere. Menu should be simpler now.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
    • python terminal.py stocks/load aapl/fa/fraud
    • python terminal.py stocks/load aapl/fa/dupont
    • python terminal.py "stocks/scr/set --preset cheap_dividend/historical"
    • python terminal.py stocks/load amzn/ba/interest
    • python terminal.py /stocks/scr/
      • Tested: overview, valuation, financial, ownership, performance, technical, extensively
  • Ensure the SDK still works
    • openbb.fa.fraud("TSLA")
    • openbb.fa.dupont("TSLA")
  • Check any related reports
    • python terminal.py reports/equity tsla

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@colin99d colin99d added the bug Fix bug label Nov 18, 2022
@reviewpad reviewpad bot added the feat XS Extra small feature label Nov 18, 2022
@colin99d colin99d marked this pull request as draft November 18, 2022 10:38
@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Nov 18, 2022
@colin99d colin99d marked this pull request as ready for review November 18, 2022 11:59
@reviewpad reviewpad bot added the feat M Medium T-Shirt size feature label Nov 18, 2022
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok overall.

Except:`

2022 Nov 18, 08:52 :) /stocks/scr/ $ set --preset break_out_stocks


2022 Nov 18, 08:53 :) /stocks/scr/ $ historical

Error: local variable 'final_screener' referenced before assignment

Error: not enough values to unpack (expected 3, got 0)

@Chavithra Chavithra self-requested a review November 18, 2022 13:49
@Chavithra Chavithra added the do not merge Label to prevent pull request merge label Nov 18, 2022
@jmaslek jmaslek merged commit cca41d4 into main Nov 18, 2022
@jmaslek jmaslek deleted the bug_squshing branch November 18, 2022 14:08
@Chavithra Chavithra removed the do not merge Label to prevent pull request merge label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat M Medium T-Shirt size feature feat S Small T-Shirt size Feature feat XS Extra small feature
Projects
None yet
3 participants