Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crypto 3327 #3434

Merged
merged 36 commits into from
Nov 21, 2022
Merged

Fix crypto 3327 #3434

merged 36 commits into from
Nov 21, 2022

Conversation

hjoaquim
Copy link
Contributor

@hjoaquim hjoaquim commented Nov 16, 2022

Description

  • Summary of the change / bug fix. / Link # issue, if applicable.

    Fix [Bug] SDK - openbb.crypto.find - no DataFrame passed. #3327
    Split the find function into a view and a model - also, added tests for it.

  • Screenshot of the feature or the bug before/after fix, if applicable.

    • Before: see issue
    • After:
      image
  • Relevant motivation and context.
    🐛 ☠️

  • List any dependencies that are required for this change.
    NA

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
from openbb_terminal.sdk import openbb
openbb.crypto.find(query="doge", key="name")
openbb.crypto.find(query="doge", key="name", chart=True)
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XL Extra Large feature label Nov 16, 2022
@hjoaquim hjoaquim self-assigned this Nov 16, 2022
@hjoaquim hjoaquim added bug Fix bug crypto Crypto related labels Nov 16, 2022
@hjoaquim hjoaquim marked this pull request as ready for review November 16, 2022 15:28
@jmaslek
Copy link
Collaborator

jmaslek commented Nov 17, 2022

So I think this function does not need a view.

@hjoaquim
Copy link
Contributor Author

I see your point @jmaslek. Should we add print_rich_table and export_data directly on the controller?

@jmaslek
Copy link
Collaborator

jmaslek commented Nov 21, 2022

I think we can just remove the view from the trail map.

@hjoaquim hjoaquim merged commit 976d5df into main Nov 21, 2022
@hjoaquim hjoaquim deleted the fix_crypto_3327 branch November 22, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug crypto Crypto related feat XL Extra Large feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] SDK - openbb.crypto.find - no DataFrame passed.
2 participants