Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bugs #3433

Merged
merged 7 commits into from
Nov 17, 2022
Merged

Fix Bugs #3433

merged 7 commits into from
Nov 17, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Nov 16, 2022

Description

Fixes #3428

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
    • python terminal.py "alternative/covid/country --country us/ov"
  • Ensure the SDK still works
  • alt.covid.ov("Us")
  • Check any related reports

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@reviewpad reviewpad bot added the feat XS Extra small feature label Nov 16, 2022
@jmaslek
Copy link
Collaborator

jmaslek commented Nov 16, 2022

broked it

Screen Shot 2022-11-16 at 8 35 50 AM

@colin99d
Copy link
Contributor Author

I knew this was in there but I didnt think we needed to add as much error handling here. Do you want this checking in the models as well?

@colin99d
Copy link
Contributor Author

Screenshot 2022-11-17 at 2 24 09 PM

@jmaslek jmaslek merged commit 968ff58 into main Nov 17, 2022
@jmaslek jmaslek deleted the squash_bugs branch November 17, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] alternative/covid sub-menu not working for United states
2 participants