-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portfolio docstring example fixes and some bugs #3431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're touching docstrings here, can you run pydocstyle
on the portfolio folder?
yes sir |
All good in the portfolio main menu files (except controller). The optimization I'll look in other PR will be working tday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me.
Description
metric volatility
unitsprint_help
PortfolioEngine
class to its own fileportfolio_engine.py
metrics
calculations tometrics_model.py
file to followallocation_model.py
andattribution_model.py
yahoofinance_model.py
andreportlab_helpers.py
toportfolio_analysis
folderHow has this been tested?
python -m doctest -v openbb_terminal/portfolio/portfolio_model.py
python terminal.py ~/OpenBBTerminal/openbb_terminal/miscellaneous/scripts/portfolio/test_portfolio.openbb