Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oanda Bug #3426

Merged
merged 4 commits into from
Nov 17, 2022
Merged

Oanda Bug #3426

merged 4 commits into from
Nov 17, 2022

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Nov 15, 2022

Fixes #3390 issue was that oanda needed to be capitalized rip

@jmaslek jmaslek added the bug Fix bug label Nov 15, 2022
@reviewpad reviewpad bot added the feat XS Extra small feature label Nov 15, 2022
piiq
piiq requested changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@piiq piiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't push to your fork.

image

to fix this change capitalized Oanda to regular oanda on line 57
image

@jmaslek
Copy link
Collaborator Author

jmaslek commented Nov 17, 2022

Can't push to your fork.

image

to fix this change capitalized Oanda to regular oanda on line 57 image

This is currently not present on my branch? Its just the lowercase one.

Screen Shot 2022-11-17 at 9 03 59 AM

@jmaslek jmaslek requested a review from piiq November 17, 2022 14:23
Chavithra
Chavithra approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@jmaslek jmaslek merged commit 1435227 into OpenBB-finance:main Nov 17, 2022
@jmaslek jmaslek deleted the oanda_bug branch November 17, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chavithra Chavithra Chavithra approved these changes

@piiq piiq Awaiting requested review from piiq

Assignees

@DidierRLopes DidierRLopes

@colin99d colin99d

Labels
bug Fix bug feat XS Extra small feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] forex/oanda bug when oanda key is not set
5 participants
@jmaslek @Chavithra @piiq @DidierRLopes @colin99d