-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3326 #3425
Merged
Merged
Fix #3326 #3425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of the change / bug fix. / Link # issue, if applicable.
Fix [Bug] SDK
openbb.crypto.dd.events
- DataFrame is not returned by the function. #3326The goal of this PR is to have the same on view/model from the sdk point of view.
To do that it was necessary to remove
get_coinpaprika_id
function and only use it on the model.Took the opportunity to do some cleaning.
Screenshot of the feature or the bug before/after fix, if applicable.
Before - on the issue.
After -
Relevant motivation and context.
🐛 💀
List any dependencies that are required for this change.
NA
How has this been tested?
On a jupyter notebook:
On the terminal:
Checklist:
Update our Hugo documentation following these guidelines.
NA
Update our tests following these guidelines.
Make sure you are following our CONTRIBUTING guidelines.
If a feature was added make sure to add it to the corresponding scripts file.
NA
Others