Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3326 #3425

Merged
merged 22 commits into from
Nov 16, 2022
Merged

Fix #3326 #3425

merged 22 commits into from
Nov 16, 2022

Conversation

hjoaquim
Copy link
Contributor

@hjoaquim hjoaquim commented Nov 15, 2022

Description

  • Summary of the change / bug fix. / Link # issue, if applicable.

    Fix [Bug] SDK openbb.crypto.dd.events - DataFrame is not returned by the function. #3326
    The goal of this PR is to have the same on view/model from the sdk point of view.
    To do that it was necessary to remove get_coinpaprika_id function and only use it on the model.
    Took the opportunity to do some cleaning.

  • Screenshot of the feature or the bug before/after fix, if applicable.

    Before - on the issue.
    After -
    image

  • Relevant motivation and context.
    🐛 💀

  • List any dependencies that are required for this change.
    NA

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works
    On a jupyter notebook:
from openbb_terminal.sdk import openbb
openbb.crypto.ov.coin_list()
openbb.crypto.dd.events(symbol = 'BTC')
openbb.crypto.dd.events(symbol = 'BTC', chart = True)
openbb.crypto.dd.ex(symbol='BTC', chart=True)
openbb.crypto.dd.ex(symbol='BTC')
openbb.crypto.dd.mkt(from_symbol='BTC', chart=True)
openbb.crypto.dd.mkt(symbol='BTC')
openbb.crypto.dd.twitter(symbol='BTC', chart=True)
openbb.crypto.dd.twitter(symbol='BTC')
openbb.crypto.dd.ps(from_symbol='BTC', chart=True)
openbb.crypto.dd.ps(symbol='BTC')
openbb.crypto.dd.basic(symbol='BTC', chart=True)
openbb.crypto.dd.basic(symbol='BTC')
openbb.crypto.dd.coin()
  • Check any related reports
    On the terminal:
reports
crypto --symbol btc

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@hjoaquim hjoaquim added bug Fix bug crypto Crypto related labels Nov 15, 2022
@hjoaquim hjoaquim self-assigned this Nov 15, 2022
@reviewpad reviewpad bot added the feat M Medium T-Shirt size feature label Nov 15, 2022
@reviewpad reviewpad bot added the feat XL Extra Large feature label Nov 15, 2022
@hjoaquim hjoaquim marked this pull request as ready for review November 15, 2022 16:10
@hjoaquim hjoaquim marked this pull request as draft November 15, 2022 17:25
@hjoaquim hjoaquim marked this pull request as ready for review November 16, 2022 11:26
@hjoaquim hjoaquim merged commit c9be115 into OpenBB-finance:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug crypto Crypto related feat M Medium T-Shirt size feature feat XL Extra Large feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] SDK openbb.crypto.dd.events - DataFrame is not returned by the function.
3 participants