-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes #3423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did you mean to sneak in the integration test stuff? |
jmaslek
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the merge conflicts then we good
@jmaslek @jose-donato pages runs fine on local and I changed nothing, do you know whats up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3418
Fixes #3397
Fixes #3391
Fixes #3387
How has this been tested?
python terminal.py stocks/ca
(look at get command with description)python terminal.py stocks/load gme/ca/
->cashflow --export csv"
(then open csv generated)python terminal.py stocks/load gme/ca/
->income --export csv"
(then open csv generated)python terminal.py stocks/load gme/ca/
->balance --export csv"
(then open csv generated)python terminal.py stocks/load aapl/fa/warnings
(see that chart matches old chart)python terminal.py /stocks/ba/snews
(see warning when no ticker set)openbb.stocks.ca.cashflow(["TSLA"])
openbb.stocks.ca.balance(["TSLA"])
openbb.stocks.ca.income(["TSLA"])
openbb.stocks.ba.snews("TSLA")
openbb.stocks.ba.snews("")
python terminal.py reports/equity amc
@Reviewer, is there a reason we don have stocks.fa.warnings on SDK? Should I add?
@Reviewer, I accidentally built this on top of another PR, lets merge this once my Integration Tests pr is done.
Checklist:
Others