Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #3423

Merged
merged 37 commits into from
Nov 22, 2022
Merged

Bug fixes #3423

merged 37 commits into from
Nov 22, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Nov 15, 2022

Description

Fixes #3418
Fixes #3397
Fixes #3391
Fixes #3387

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
    • python terminal.py stocks/ca (look at get command with description)
    • python terminal.py stocks/load gme/ca/ -> cashflow --export csv" (then open csv generated)
    • python terminal.py stocks/load gme/ca/ -> income --export csv" (then open csv generated)
    • python terminal.py stocks/load gme/ca/ -> balance --export csv" (then open csv generated)
    • python terminal.py stocks/load aapl/fa/warnings (see that chart matches old chart)
    • python terminal.py /stocks/ba/snews (see warning when no ticker set)
  • Ensure the SDK still works
    • openbb.stocks.ca.cashflow(["TSLA"])
    • openbb.stocks.ca.balance(["TSLA"])
    • openbb.stocks.ca.income(["TSLA"])
    • openbb.stocks.ba.snews("TSLA")
    • openbb.stocks.ba.snews("")
  • Check any related reports
    • python terminal.py reports/equity amc

@Reviewer, is there a reason we don have stocks.fa.warnings on SDK? Should I add?
@Reviewer, I accidentally built this on top of another PR, lets merge this once my Integration Tests pr is done.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@colin99d colin99d added the bug Fix bug label Nov 15, 2022
@reviewpad reviewpad bot added the feat M Medium T-Shirt size feature label Nov 15, 2022
@jmaslek
Copy link
Collaborator

jmaslek commented Nov 15, 2022

Did you mean to sneak in the integration test stuff?

Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the merge conflicts then we good

@reviewpad reviewpad bot added the feat XS Extra small feature label Nov 21, 2022
@colin99d
Copy link
Contributor Author

@jmaslek @jose-donato pages runs fine on local and I changed nothing, do you know whats up?

@jmaslek jmaslek merged commit 5c14e28 into main Nov 22, 2022
@jmaslek jmaslek deleted the bug_fixes branch November 22, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug feat M Medium T-Shirt size feature feat XS Extra small feature
Projects
None yet
2 participants