Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change common trails to no trails #3419

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Change common trails to no trails #3419

merged 3 commits into from
Nov 14, 2022

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Nov 14, 2022

Instead of the confusing notation of openbb.common.ta.cmd, I removed the leading trail so that we can do openbb.ta.cmd

@jmaslek jmaslek added the platform OpenBB Platform label Nov 14, 2022
Chavithra
Chavithra approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@reviewpad reviewpad bot added the feat L Large T-Shirt size Feature label Nov 14, 2022
@jmaslek jmaslek merged commit cef1fca into OpenBB-finance:main Nov 14, 2022
@jmaslek jmaslek deleted the common_trail branch November 14, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chavithra Chavithra Chavithra approved these changes

Assignees

@Chavithra Chavithra

Labels
feat L Large T-Shirt size Feature platform OpenBB Platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmaslek @Chavithra