Refactor option chain for sdk #3414

jmaslek · 2022-11-14T18:22:50Z

Previously we mapped chain to just yahoo. This allows the user to specify the source to get chains :P

This whole menu needs a solid refactoring, but kinda out of scope here.

Note I am looking through and see we have

stocks.options.chains
stocks.options.chains_yf
stocks.options.option_chain

EDIT: I changed my mind and made chains the default sdk way of getting option chain. FYI: this fixes #3283

Adding in an edit for Fixes #3325, where I ported this sdk helper and added expirations to the trail map.

Refactor option chain for sdk

0293372

jmaslek added the platform OpenBB Platform label Nov 14, 2022

jmaslek requested a review from Chavithra November 14, 2022 18:22

jmaslek added 5 commits November 14, 2022 13:27

Lint

d886a5d

Executive decision about chains function

d34ae9b

Allow chains to specify an expiry

f2bff67

Fix docstring +fix test + isort

825cecc

trail map merge

2a969a3

reviewpad bot added the feat L Large T-Shirt size Feature label Nov 14, 2022

Merge branch 'main' into options_refactor

57b8eba

reviewpad bot added the feat S Small T-Shirt size Feature label Nov 14, 2022

jmaslek added 4 commits November 14, 2022 16:59

Remove some unnecessary trails

373f262

Fixes OpenBB-finance#3325

da31640

Faster expirations

91b2b12

This is why we dont skip pre commit

76dc2b2

jmaslek force-pushed the options_refactor branch from 0e89f6a to 76dc2b2 Compare November 15, 2022 13:28

Merge branch 'main' into options_refactor

35d8653

colin99d self-requested a review November 15, 2022 14:06

colin99d approved these changes Nov 15, 2022

View reviewed changes

colin99d merged commit 8bf8201 into OpenBB-finance:main Nov 15, 2022

jmaslek deleted the options_refactor branch February 14, 2024 21:31

Provide feedback