-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added single block data from Blockchain.com #3406
Added single block data from Blockchain.com #3406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to test it locally but looking nice!! request a few minor changes
Thank you for this 🤝 🚀
Thanks! I'll get on those changes this weekend. |
Hey @noubre, Sorry for the delay to review on our side. As per our discussion, we are currently doing a feature freeze for a very big release that will occur next week! Once that is out of the way, we will test this PR and give feedback. Thanks for contributing! 🙏🏽 |
@DidierRLopes No problem, thanks! |
Hey, going through this again! Thanks again, this is amazing and will be interesting for the future refactor im planning for the crypto menu. Requests:
TODO in the future:
Let me know if you need any help with any of this. |
@jose-donato I'll right on those changes. Thanks! By the way, the new terminal 2.0 looks great! |
@noubre thanks for the quickness 😄 |
a2a3a43
to
629850f
Compare
…lockData # Conflicts: # openbb_terminal/cryptocurrency/onchain/blockchain_view.py # openbb_terminal/cryptocurrency/onchain/onchain_controller.py # openbb_terminal/sdk.py # reviewpad.yaml # tests/openbb_terminal/cryptocurrency/onchain/test_blockchain_view.py # website/data/menu/main.yml # website/generate_sdk_markdown.py # website/generate_terminal_markdown.py # website/old_content/terminal/stocks/th/_index.md # website/package.json # website/src/components/General/ShowcaseItem.tsx # website/src/theme/CodeBlock/Content/String.js # website/src/theme/Tabs/index.js
|
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! 👍 just need to wait for the tests to run
This was a rough one due to the launch of terminal 2.0 |
Thanks! Can't wait to do it again. Thanks for your help! |
Added the API for pulling single block JSON data from Blockchain.com. The motivation for this is expand the available API's for BTC blockchain data on the terminal, several more are in the process of being tested. No new dependencies are needed for this addition.
How has this been tested?
Checklist: