Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style fixing: removing --ascend/--descend #3395

Merged
merged 26 commits into from
Nov 14, 2022

Conversation

hjoaquim
Copy link
Contributor

@hjoaquim hjoaquim commented Nov 11, 2022

Description

  • Summary of the change / bug fix.

    • removing --ascend/--descend for --reverse
    • args with multiple options should be comma separated
  • Screenshot of the feature or the bug before/after fix, if applicable.

    • e.g:
      image

    • e.g 2 (Before/ After):
      image

  • Relevant motivation and context.

    • Consistent style

How has this been tested?

Manually run the affected commands.
Run the integration tests.

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
  • Make sure affected commands still run in terminal
  • Ensure the SDK still works //] Check any related reports
    • Changes on a controller shouldn't affect the SDK.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

@hjoaquim hjoaquim added the refactor Refactor code label Nov 11, 2022
@hjoaquim hjoaquim self-assigned this Nov 11, 2022
@hjoaquim hjoaquim marked this pull request as ready for review November 14, 2022 10:15
@hjoaquim
Copy link
Contributor Author

@jmaslek despite the tittle, I've added this commit also on this PR as it was a single case.

@hjoaquim
Copy link
Contributor Author

@jmaslek sorry this got quite big 😞

@hjoaquim hjoaquim merged commit 0ae89d6 into OpenBB-finance:main Nov 14, 2022
@hjoaquim hjoaquim deleted the style_fixing branch November 14, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants